BUGFIX: Scroll to focused element in guest frame #4066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves a regression in Neos 9.1 when the toolbar was refactored to a functional component. The focusedNode in the state was still the previous node in the function instead of the newly selected one. With this change we make sure that the focusedNode matches the updated state with the scroll request. Resolves: #4064
mhsdesign
approved these changes
Jan 17, 2026
Member
mhsdesign
left a comment
mhsdesign
left a comment
There was a problem hiding this comment.
Yes fetching state twice can lead to some funky behaviour:D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves a regression in Neos 9.1 when the toolbar was refactored to a functional component. The focusedNode in the state was still the previous node in the function instead of the newly selected one. With this change we make sure that the focusedNode matches the updated state with the scroll request.
Resolves: #4064