Skip to content

Conversation

@Jan3k3y
Copy link

@Jan3k3y Jan3k3y commented Dec 5, 2025

Feature: #5652

Previous MR: #5658
-> recreated cause maintainers could not maintain

Upgrade instructions

existing svg will have no dimensions which should be generated via ./flow media:refreshsvgdimensions
newly added/uploaded svg files will automatically have dimensions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

Copy link
Member

@mficzel mficzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhsdesign I would like to discuss this:

  • On the one hand i really think we should have svg dimensions and cropping
  • On the other hand the solution is really hacky ... and i must know it since i made the template

It may be wise to take this topic to the media sprint and nut rush a fearture in that later on limits us. I mean those that like to live dangerous can use the sitegeist package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants