FEATURE: Add fromClassAndMethodName() to LogEnvironment #3419
+21
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does some code cleanup and adds a new method `fromClassAndMethodName($className, $methodName)` to the `LogEnvironment`.
It be used like this:
LogEnvironment::fromClassAndMethodName(__CLASS__, __METHOD__)
and will return useful data – as opposed to `LogEnvironment::fromMethodName(__METHOD__)`, which only works for static methods (`SomeClass::someMethod` or closures).
robertlemke
reviewed
Dec 3, 2024
| * under the key FLOW_LOG_ENVIRONMENT to be set as part of the | ||
| * additional data in an log method call. | ||
| */ | ||
| public static function fromClassAndMethodName(string $className, string $methodName): array |
Member
There was a problem hiding this comment.
What if we also allow passing an object instead of the class name? That way you could just pass $this in most cases.
public static function fromClassAndMethodName(string|object $class, string $methodName): array
{
$className = is_object($class) ? get_class($object) : $className;
...
Member
Author
There was a problem hiding this comment.
Does that make it easier to use? You can even use $this::class if you like…
Member
|
Why is this a task and not a new (tiny) feature? |
Member
Author
So I can sneak it into 8.3… 😎 |
kdambekalns
changed the title
dlubitz
approved these changes
Jan 23, 2025
markusguenther
approved these changes
Sep 26, 2025
Member
markusguenther
left a comment
markusguenther
left a comment
There was a problem hiding this comment.
Fine, thank you @kdambekalns
It is a tiny tiny feature, but not sure if we should merge it in 8.3 or better 8.4 or so
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does some code cleanup and adds a new method
fromClassAndMethodName($className, $methodName)to theLogEnvironment.It be used like this:
and will return useful data – as opposed to
LogEnvironment::fromMethodName(__METHOD__), which only works for static methods (SomeClass::someMethodor closures).Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions