-
Notifications
You must be signed in to change notification settings - Fork 86
Added CMake support. #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…facilitate this. Updated meson.build and Makefile to reflect new directory structure. Updated README.md to explain how to integrate µnit into a project using CMake.
nemequ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with adding CMake support, but I don't want to rename the files since it would break existing code… If you're willing to rework this a bit so munit.{c,h} aren't renamed I'd be happy to merge it.
|
I'm currently using µnit in my project which is built with CMake, and I'll be delighted if this PR gets merged. I agree with @nemequ with the fact that it would be better to keep the source files in the root to retain support for existing codebases. It might not be the most aesthetic thing to keep the sources outside |
…original locations
|
@nemequ, that sounds reasonable. I've put the source/include files back in their original locations. Let me know if you would like anything else changed. |
|
I notice that the CMake file hard-codes |
So this was intentional, but happy to change this if the consensus is that this isn't sane. |
|
I am okay with hard-coded Release mode in this case. Anyone else have thoughts? |
|
@thomasfsteeples I have written a CMake module along with a helper cmake file with function The files in this gist could be useful for inclusion in this PR to simplify the usage of CMake with Munit. |
|
It was too bad to change the c standard and use some kind of flags for global, can break existing code which include this project with itself. Check pr with #100 |
Added CMake support. Created new src and include directories to help facilitate this. Updated meson.build and Makefile to reflect new directory structure. Updated README.md to explain how to integrate µnit into a project using CMake.