fix: support nested/chained annotated tags (e.g., gradle/actions@v4)#5986
Open
hhgyu wants to merge 2 commits intonektos:masterfrom
Open
fix: support nested/chained annotated tags (e.g., gradle/actions@v4)#5986hhgyu wants to merge 2 commits intonektos:masterfrom
hhgyu wants to merge 2 commits intonektos:masterfrom
Conversation
Add support for resolving nested annotated tags where a tag points to another tag instead of directly to a commit (e.g., v4 -> v4.4.4 -> commit). This fixes the "unsupported object type" error when using actions like gradle/actions@v4 which use chained annotated tags. Changes: - Add resolveTagToCommit() to recursively resolve tag chains - Add resolveRefToCommit() wrapper for graceful fallback - Update NewGitCloneExecutor to use the new resolver - Add comprehensive tests for nested tag scenarios
|
Can this be merged and released please as still having this nested/chained annotation issues with act |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using actions with nested annotated tags (where a tag points to
another tag instead of a commit), act fails with:
Unable to resolve v4: unsupported object type
This affects actions like:
gradle/actions@v4borales/actions-yarn@v4pr-mpt/actions-commit-hash@v2These use a chained tag structure:
vX(tag) →vX.x.x(tag) → commitSolution
Add recursive tag resolution to handle nested annotated tags:
resolveTagToCommit(): Recursively dereferences tag chains until reaching a commitresolveRefToCommit(): Wrapper that tries standard resolution first, falls back to nested tag handlingTesting
gradle/actions@v4Fixes #5862
Fixes #1600
Related: #1545