Skip to content

Add 24.04 images, override -latest with -24.04 #5951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
keks wants to merge 4 commits into
base: master
Choose a base branch
from
+28 −5
Open

Add 24.04 images, override -latest with -24.04 #5951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
61c7349
chore: add 24.04 images, override -latest with -24.04
keks Oct 19, 2025
36a2f83
fix: address review feedback, fix typos
keks Oct 31, 2025
63df582
add warning when we find outdated image alias
keks Oct 31, 2025
448c8e9
fix warning conditions
keks Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion IMAGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@

| Image | Size |
| ------------------------------------- | ---------------------------------------------------------- |
| [`node:16-bookworm`][hub/_/node] | ![`bookworm-size`][hub/_/node/16-bookworm/size] |
| [`node:16-bookworm-slim`][hub/_/node] | ![`micro-bookworm-size`][hub/_/node/16-bookworm-slim/size] |
| [`node:16-bullseye`][hub/_/node] | ![`bullseye-size`][hub/_/node/16-bullseye/size] |
| [`node:16-bullseye-slim`][hub/_/node] | ![`micro-bullseye-size`][hub/_/node/16-bullseye-slim/size] |
| [`node:16-buster`][hub/_/node] | ![`buster-size`][hub/_/node/16-buster/size] |
Expand All @@ -19,7 +21,7 @@

| Image | GitHub Repository |
| ------------------------------------------------------------ | ------------------------------------------------------------- |
| [`catthehacker/ubuntu:act-latest`][ghcr/catthehacker/ubuntu] | [`catthehacker/docker-images`][gh/catthehacker/docker_images] |
| [`catthehacker/ubuntu:act-24.04`][ghcr/catthehacker/ubuntu] | [`catthehacker/docker-images`][gh/catthehacker/docker_images] |
| [`catthehacker/ubuntu:act-22.04`][ghcr/catthehacker/ubuntu] | [`catthehacker/docker-images`][gh/catthehacker/docker_images] |
| [`catthehacker/ubuntu:act-20.04`][ghcr/catthehacker/ubuntu] | [`catthehacker/docker-images`][gh/catthehacker/docker_images] |
| [`catthehacker/ubuntu:act-18.04`][ghcr/catthehacker/ubuntu] | [`catthehacker/docker-images`][gh/catthehacker/docker_images] |
Expand All @@ -44,6 +46,8 @@ Feel free to make a pull request with your image added here

[hub/_/buildpack-deps]: https://hub.docker.com/_/buildpack-deps
[hub/_/node]: https://hub.docker.com/r/_/node
[hub/_/node/16-bookworm/size]: https://img.shields.io/docker/image-size/_/node/16-bookworm
[hub/_/node/16-bookworm-slim/size]: https://img.shields.io/docker/image-size/_/node/16-bookworm-slim
[hub/_/node/16-bullseye/size]: https://img.shields.io/docker/image-size/_/node/16-bullseye
[hub/_/node/16-bullseye-slim/size]: https://img.shields.io/docker/image-size/_/node/16-bullseye-slim
[hub/_/node/16-buster/size]: https://img.shields.io/docker/image-size/_/node/16-buster
Expand Down
3 changes: 2 additions & 1 deletion cmd/platforms.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ import (

func (i *Input) newPlatforms() map[string]string {
platforms := map[string]string{
"ubuntu-latest": "node:16-buster-slim",
"ubuntu-latest": "node:16-bookworm-slim",
"ubuntu-24.04": "node:16-bookworm-slim",
"ubuntu-22.04": "node:16-bullseye-slim",
"ubuntu-20.04": "node:16-buster-slim",
"ubuntu-18.04": "node:16-buster-slim",
Expand Down
24 changes: 21 additions & 3 deletions cmd/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,12 @@ func readArgsFile(file string, split bool) []string {
for scanner.Scan() {
arg := os.ExpandEnv(strings.TrimSpace(scanner.Text()))

if arg == "-P ubuntu-latest=catthehacker/ubuntu:full-latest" ||
arg == "-P ubuntu-latest=catthehacker/ubuntu:act-latest" ||
arg == "-P ubuntu-latest=node:16-buster-slim" {
log.Warn("actrc contains outdated default aliases. To regenerate it, remove the file. For details, see https://github.com/nektos/act/pull/5951.")
}

if strings.HasPrefix(arg, "-") && split {
args = append(args, regexp.MustCompile(`\s`).Split(arg, 2)...)
} else if !split {
Expand Down Expand Up @@ -730,11 +736,23 @@ func defaultImageSurvey(actrc string) error {
var option string
switch answer {
case "Large":
option = "-P ubuntu-latest=catthehacker/ubuntu:full-latest\n-P ubuntu-22.04=catthehacker/ubuntu:full-22.04\n-P ubuntu-20.04=catthehacker/ubuntu:full-20.04\n-P ubuntu-18.04=catthehacker/ubuntu:full-18.04\n"
option = "-P ubuntu-latest=catthehacker/ubuntu:full-24.04\n" +
"-P ubuntu-24.04=catthehacker/ubuntu:full-24.04\n" +
"-P ubuntu-22.04=catthehacker/ubuntu:full-22.04\n" +
"-P ubuntu-20.04=catthehacker/ubuntu:full-20.04\n" +
"-P ubuntu-18.04=catthehacker/ubuntu:full-18.04\n"
case "Medium":
option = "-P ubuntu-latest=catthehacker/ubuntu:act-latest\n-P ubuntu-22.04=catthehacker/ubuntu:act-22.04\n-P ubuntu-20.04=catthehacker/ubuntu:act-20.04\n-P ubuntu-18.04=catthehacker/ubuntu:act-18.04\n"
option = "-P ubuntu-latest=catthehacker/ubuntu:act-24.04\n" +
"-P ubuntu-24.04=catthehacker/ubuntu:act-24.04\n" +
"-P ubuntu-22.04=catthehacker/ubuntu:act-22.04\n" +
"-P ubuntu-20.04=catthehacker/ubuntu:act-20.04\n" +
"-P ubuntu-18.04=catthehacker/ubuntu:act-18.04\n"
case "Micro":
option = "-P ubuntu-latest=node:16-buster-slim\n-P ubuntu-22.04=node:16-bullseye-slim\n-P ubuntu-20.04=node:16-buster-slim\n-P ubuntu-18.04=node:16-buster-slim\n"
option = "-P ubuntu-latest=node:16-bookworm-slim\n" +
"-P ubuntu-24.04=node:16-bookworm-slim\n" +
"-P ubuntu-22.04=node:16-bullseye-slim\n" +
"-P ubuntu-20.04=node:16-buster-slim\n" +
"-P ubuntu-18.04=node:16-buster-slim\n"
}

f, err := os.Create(actrc)
Expand Down