Merge Develop to Master, release v5.28.0 #187
Conversation
Refactor: notifications
- Rename variables and methods to make a clear distinction between OntoPortal site admins, ontology admins and support. - Add new feature to optionally disable notifications send to OntoPortal admins for each event associated with ontology creation, new user, etc - LinkedData.setting.support_contact_email is a new configuration option for setting end user support contact email. BioPortal requires different emails for contacting BioPortal site admins and end user support In order to clarify the distinction between the OntoPortal site admins and ontology owners/admins the following settings and methods are renamed: LinkedData.setting.admin_emails is renamed to ontoportal_admin_emails LinkedData::Utils::Notifier.admin_mails -> ontology_admin_emails LinkedData::Utils::support_mails -> ontoportal_admin_emails LinkedData::Utils::notify_support_grouped -> notify_ontoportal_admins_grouped
refactor notification
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #187 +/- ##
==========================================
- Coverage 80.76% 79.96% -0.80%
==========================================
Files 63 64 +1
Lines 4917 4957 +40
==========================================
- Hits 3971 3964 -7
- Misses 946 993 +47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
add attribute for storing reset token expire time
alexskr
changed the title
|
The screenshot below was provided as an example of the notification that an ontology owner receives after a successful processing. The text of "Parsed successfully" directly followed by "Obsolete" is confusing, and I believe will generate traffic on our support list from users asking what this means. I object to releasing this in production without addressing this.
|
|
|
addressed by c77d0b3 |
Changes: