Add SSL Verification Options and Improved Certificate Handling #817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `verify_ssl` parameter to DownloadsConfig to control SSL certificate verification - Update client methods to use the new SSL verification setting - Add CLI option `--no-ssl-verify` to disable SSL verification - Implement SSL verification support across various clients and network requests - Add test suite to validate SSL verification configuration
- Add new `ssl_utils.py` module for SSL certificate management - Implement optional certifi package support for improved certificate verification - Add utility functions for creating SSL contexts and handling connector kwargs - Update various clients to use new SSL utility functions - Add helpful error messaging for SSL certificate verification issues - Include optional certifi dependency in pyproject.toml
- Add comprehensive test suite for SSL verification utilities - Implement tests for SSL context creation and configuration - Update test configuration to include verify_ssl option - Add test coverage for SSL verification across different clients and methods - Improve error handling and testing for SSL-related configurations
Owner
|
Nice! I tested with TIDAL and seems to work. Can you make sure the checks pass? |
Contributor
Author
|
sure thing! ran |
EllipPro
added a commit
to EllipPro/streamrip
that referenced
this pull request
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds SSL certificate verification options, addressing the certificate verification issues.
Changes
streamrip/utils/ssl_utils.pywith helper functions for SSL context creationverify_sslparameter to network clients and API functionscertifian optional dependency for certificate verification--no-ssl-verifyCLI option for troubleshootingTesting
Related issues:
Resolves #784
Resolves #747
Resolves #548
Resolves #775
I don't have access to a windows machine, so someone testing it in a windows environment would be appreciated.