Fix nasa/cFS#703, Reduce stack usage in UT_CallTaskPipe#2674
Open
heathdutton wants to merge 1 commit intonasa:mainfrom
Open
Fix nasa/cFS#703, Reduce stack usage in UT_CallTaskPipe#2674heathdutton wants to merge 1 commit intonasa:mainfrom
heathdutton wants to merge 1 commit intonasa:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Moves the large message buffer in
UT_CallTaskPipe()from stack to static storage. The buffer isCFE_MISSION_SB_MAX_SB_MSG_SIZEbytes (32KB by default), which exceeds the default RTEMS task stack size of 20KB configured inbsp_start.c.Fixes nasa/cFS#703
Testing performed
Code review and verification that the change follows existing patterns in the file (other static buffers like
UT_CFE_ES_ResetData).Expected behavior changes
Unit tests will no longer overflow the stack on systems with constrained stack sizes (e.g., RTEMS with default 20KB stacks).
System(s) tested on
Code review only (macOS development environment does not support cFS build)
Contributor Info - All information REQUIRED for consideration of pull request
Heath Dutton