Skip to content

Comments

Fix #1461, Move data lock to inside of if block#2198

Open
thnkslprpt wants to merge 1 commit intonasa:mainfrom
thnkslprpt:fix-1461-move-data-lock-inside-if-block
Open

Fix #1461, Move data lock to inside of if block#2198
thnkslprpt wants to merge 1 commit intonasa:mainfrom
thnkslprpt:fix-1461-move-data-lock-inside-if-block

Conversation

@thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Nov 8, 2022

Checklist

Describe the contribution

Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.

Expected behavior changes
Data lock will not occur in the (unexpected) case of an error return from CFE_SB_ZeroCopyBufferValidate(), which is fine as no data would be accessed/amended in that case anyway.

Contributor Info
Avi @thnkslprpt

@thnkslprpt thnkslprpt force-pushed the fix-1461-move-data-lock-inside-if-block branch from e300c81 to 544872a Compare April 19, 2024 21:35
@thnkslprpt thnkslprpt force-pushed the fix-1461-move-data-lock-inside-if-block branch from 544872a to fd06a33 Compare December 31, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reduce scope of lock to within if statement in CFE_SB_ReleaseMessageBuffer

1 participant