Skip to content

Conversation

@adriy-be
Copy link
Contributor

Description

Follow the title.
Now the ExtendedLinearAddressRecord was supported, non-continuous region generated multiple dfu elements.

The PR and code was not perfect but hope my work can help.

Motivation and Context

I'm generating a DFU from a hex, but when I flash my device, that doesn't work. It's due to ExtendedLinearAddressRecord was not supported and also my hex have non-contiguous memory.

How Has This Been Tested?

Generate the DFU with St tool and compare the dfu generated with wxHexEditor

Screenshots

Left DFU generate with ST
Right DFU generated with the tool

Before modification
image
image

after modification
image

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

I will read this Checklist When I have free time to do this. Thank you for your understanding

@josesimoes
Copy link
Member

@adriy-be is this replacing #11?

@adriy-be
Copy link
Contributor Author

@adriy-be is this replacing #11?

It may.
I also add the support type "extended linear address record".
I'm not expert in DFU and hex files. It's working in my case, but I don't have other hex to try.

@josesimoes
Copy link
Member

It may.

OK. If that's the case, then please close it with this information.

I also add the support type "extended linear address record". I'm not expert in DFU and hex files. It's working in my case, but I don't have other hex to try.

Understood. If you're confident on this let's go for it.
I would be more confident if you could update and/or add Unit Tests to cover these changes.

@adriy-be
Copy link
Contributor Author

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants