-
Notifications
You must be signed in to change notification settings - Fork 2
feat(nameguard): Add ENSNode API for primary name resolution #713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…c primary name resolution
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
The decision is that ENSNode API behaviour is the correct one (if the primary name is unnormalized then we say there is no primary name) so we need to fix tests. Probably unnormalized state in the endpoint is no longer valid. |
…ling to use ENSNode API exclusively
… to current issues
…low all tests to run
…me retrieval to streamline test suite
Tests fail because output from ENSNode API is different than from RPC.
E.g. for address 0xFD9eE68000Dc92aa6c67F8f6EB5d9d1a24086fAd we got exampleprimary.cb.id from ENSNode but null from Alchemy.
https://api.alpha.ensnode.io/api/resolve/primary-name/0xFD9eE68000Dc92aa6c67F8f6EB5d9d1a24086fAd/1 ;
https://api.alpha.ensnode.io/api/resolve/primary-name/0xc9f598bc5bb554b6a15a96d19954b041c9fdbf14/1 gives null but Alchemy returns vıtalik.eth (unnormalized)