Skip to content

Conversation

@renepusch-artner
Copy link

No description provided.

@renepusch-artner
Copy link
Author

renepusch-artner commented Nov 10, 2025

Hi, we use Nager.Country for a new project in our company.
As we use VB6, we rely on referencing strongly named assemblies.

It would be great if a quick release (on NuGet) could be done as soon as possible, because until that, we cant properly use Nager.Country :)

@tinohager
Copy link
Member

Hi,
thanks a lot for your contribution and for using Nager.Country in your project!

Unfortunately, this pull request cannot be merged as it includes the private strong name key (.snk file).
Publishing a private key would allow anyone to build assemblies that appear to be officially signed, which compromises the package’s integrity and security.

I’ll take a closer look at this topic when I get the chance and see how we can provide a strongly named version safely.
Thanks for your understanding and for bringing this up!

@arminweiglartner
Copy link

Publishing the strong naming key pair only has security implications if it has been used in the past for partial trust scenarios. This can't be the case for a newly generated key pair.

This is documented by Microsoft in https://learn.microsoft.com/en-us/dotnet/standard/library-guidance/strong-naming#when-to-strong-name-net-libraries

Copy link

@arminweiglartner arminweiglartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should only be one key pair for all projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants