Open
Conversation
Member
|
@ewassef there is no need to tag us in this, we will pick this up when it is next in the queue during working hours. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant updates to the repository to enhance deployment options for the n8n workflow automation tool. It includes the addition of
.gitattributesfor consistent line endings, comprehensive Kubernetes configurations, and updates to the documentation to reflect these changes. The Kubernetes configurations now support production-grade deployments with features like autoscaling, resource management, and security hardening.Deployment Configuration Updates:
Kubernetes Base Configurations:
kubernetes/base/kustomization.yamlto define shared resources, including deployments for n8n UI, workers, Redis, and Postgres, along with services, PVCs, and secrets.n8n-deployment.yamlandn8n-deployment-workers.yamlto separate UI and worker deployments, enabling better scalability and resource allocation. Worker replicas increased to 2 with a rolling update strategy. [1] [2]redis-deployment.yamlandredis-service.yaml) with resource limits and readiness/liveness probes. [1] [2]Production Enhancements:
ScaledObjectconfiguration (n8n-worker-scaledobject.yaml) for KEDA-based autoscaling of n8n workers using Prometheus metrics.n8n-servicemonitor.yamlfor Prometheus monitoring of n8n metrics.Documentation Updates:
Repository Overview:
README.mdto provide an overview of deployment options, including Docker Compose, Docker with Caddy, and Kubernetes. Added instructions for selecting the appropriate deployment method.Kubernetes Deployment Guide:
kubernetes/README.mdwith detailed architecture, prerequisites, deployment structure, and instructions for configuring KEDA and Prometheus.Miscellaneous Enhancements:
Line Ending Normalization:
.gitattributesto enforce consistent line endings across the repository and explicitly define binary file types.Security and Secrets:
n8n-secret.yamlfor managing sensitive data such as encryption keys.These changes collectively improve the scalability, maintainability, and deployment flexibility of the n8n automation tool.