feat: add capabilities proxy #408
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GravendeelJochem
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #408 +/- ##
============================================
+ Coverage 94.91% 94.95% +0.03%
- Complexity 2032 2048 +16
============================================
Files 359 363 +4
Lines 6642 6694 +52
============================================
+ Hits 6304 6356 +52
Misses 338 338 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds a capabilities proxy endpoint to enable communication with the Capabilities API service. The implementation follows the same pattern as the existing addresses microservice proxy.
Changes:
- Added new CapabilitiesApiService to handle API communication with the capabilities service
- Created CapabilitiesAction with CORS support for handling frontend requests
- Registered the new proxy endpoint in the frontend context configuration
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Api/Service/CapabilitiesApiService.php | New API service for communicating with the Capabilities API, handles authentication and base URL configuration |
| src/App/Action/Capabilities/CapabilitiesAction.php | New action handler with CORS support for proxying requests to the capabilities service |
| src/App/Request/Capabilities/CapabilitiesEndpointRequest.php | Request class defining the 'capabilities' property for the endpoint |
| src/Api/Response/CapabilitiesResponse.php | Response wrapper for capabilities API responses |
| src/Api/PdkCapabilitiesActions.php | Constants class defining the PROXY_CAPABILITIES action |
| config/pdk-services.php | Registers the CapabilitiesApiService in the DI container |
| config/pdk-default.php | Adds capabilitiesServiceUrl configuration with default value |
| config/actions.php | Registers the proxyCapabilities action in the frontend context and adjusts formatting for alignment |
| tests/Unit/App/Action/Capabilities/CapabilitiesActionTest.php | Comprehensive test coverage including request building, CORS handling, and OPTIONS preflight |
| tests/snapshots/ContextServiceTest__it_gets_context_data_with_data_set_delivery_options_config__1.json | Updated snapshot to include the new proxyCapabilities endpoint configuration |
| tests/snapshots/FrontendRenderServiceTest__it_renders_component_with_data_set_delivery_options__1.json | Updated snapshot to include the new proxyCapabilities endpoint configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
myparcel-bot
bot
force-pushed
the
feat/add-capabilities-proxy
branch
from
61d2a3f to
dd7dbfa
Compare
FreekVR
requested changes
Jan 21, 2026
| } | ||
|
|
||
| /** @var \MyParcelNL\Pdk\Api\Response\CapabilitiesResponse $response */ | ||
| $response = $this->apiService->doRequest($this->buildRequest($request), CapabilitiesResponse::class); |
Contributor
There was a problem hiding this comment.
Here the SDK capabilities client needs to be used rather than internal PDK API logic (see acceptance criteria)
| */ | ||
| public function buildRequest(Request $incomingRequest): ApiRequest | ||
| { | ||
| $query = $incomingRequest->query->all(); |
Contributor
There was a problem hiding this comment.
This is not the correct way to call capabilities - but using the SDK for this should make it redundant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INT-1269