Add maxBytesLocalDisk support for Ehcache 2#282
Closed
Copilot wants to merge 1 commit intosupport/ehcache2from
Closed
Add maxBytesLocalDisk support for Ehcache 2#282Copilot wants to merge 1 commit intosupport/ehcache2from
Copilot wants to merge 1 commit intosupport/ehcache2from
Conversation
Copilot
AI
changed the title
[WIP] Fix issue #62 for ehcache2 users
Fix maxBytesLocalDisk support in Ehcache 2 (support/ehcache2 backport of #62)
Mar 7, 2026
Copilot
AI
changed the title
Fix maxBytesLocalDisk support in Ehcache 2 (support/ehcache2 backport of #62)
Add maxBytesLocalDisk support for Ehcache 2
Mar 7, 2026
c82c342 to
d1394c4
Compare
Co-Authored-By: hazendaz <975267+hazendaz@users.noreply.github.com>
d1394c4 to
2fd8449
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setMaxBytesLocalDiskwas missing from the Ehcache 2 adapter, making it impossible to enforce a disk-size ceiling on MyBatis caches.Changes
AbstractEhcacheCache— addssetMaxBytesLocalDisk(long)and a protectedrebuildCacheWith(CacheConfiguration)template method. Ehcache 2 enforces mutual exclusivity betweenmaxBytesLocalDiskandmaxEntriesLocalDisk, and prohibits switching disk pool types on a live cache instance; the setter works around this by constructing a freshCacheConfiguration(preserving TTI/TTL/heap/eviction-policy) and replacing the running cache via theCacheManager.EhBlockingCache— overridesrebuildCacheWithto re-apply theBlockingCachedecorator after the underlying cache is replaced.EhcacheTest— addsshouldSetMaxBytesLocalDiskverifying the byte limit is applied,maxEntriesLocalDiskis cleared, and the cache remains operational after the rebuild.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.