Skip to content

Fix instrument change clef not reacting to concert pitch toggle#32499

Draft
CubikingChill wants to merge 1 commit intomusescore:masterfrom
CubikingChill:master
Draft

Fix instrument change clef not reacting to concert pitch toggle#32499
CubikingChill wants to merge 1 commit intomusescore:masterfrom
CubikingChill:master

Conversation

@CubikingChill
Copy link
Contributor

@CubikingChill CubikingChill commented Mar 5, 2026

Resolves: #32614

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@CubikingChill CubikingChill force-pushed the master branch 5 times, most recently from a3a6a58 to fc16de4 Compare March 5, 2026 05:20
@CubikingChill
Copy link
Contributor Author

Please do not merge at the moment. I am still working on the functionality of the code.

@CubikingChill CubikingChill force-pushed the master branch 27 times, most recently from 6a58549 to bcb2f3b Compare March 9, 2026 17:22

for (size_t i = 0; i < part->nstaves(); i++) {
Staff* staff = part->staff(i);
// 直接獲取當前樂器定義的 ClefTypeList (包含 cp 和 tp)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code comments in English please.

If these are just notes to help you understand things and remember what they do, that's fine. Just make sure you remove them all (or rewrite them in English) before you mark the PR as "ready for review".

But if you're using AI, we shouldn't be able to tell. The code should look how it would look if you had written it all yourself; the AI should just be used to arrive at the end result sooner.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your guess is correct. I am using some level of AI to skip reading all existing code. But I can assure you that once this PR goes out of draft. It will be clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MU4] Fix Instrument Change Clef Synchronization in Concert Pitch Mode

2 participants