Fix instrument change clef not reacting to concert pitch toggle#32499
Fix instrument change clef not reacting to concert pitch toggle#32499CubikingChill wants to merge 1 commit intomusescore:masterfrom
Conversation
a3a6a58 to
fc16de4
Compare
|
Please do not merge at the moment. I am still working on the functionality of the code. |
dbac1f6 to
09ef22a
Compare
e2d3dcb to
5852a5f
Compare
6a58549 to
bcb2f3b
Compare
src/engraving/dom/instrchange.cpp
Outdated
|
|
||
| for (size_t i = 0; i < part->nstaves(); i++) { | ||
| Staff* staff = part->staff(i); | ||
| // 直接獲取當前樂器定義的 ClefTypeList (包含 cp 和 tp) |
There was a problem hiding this comment.
Code comments in English please.
If these are just notes to help you understand things and remember what they do, that's fine. Just make sure you remove them all (or rewrite them in English) before you mark the PR as "ready for review".
But if you're using AI, we shouldn't be able to tell. The code should look how it would look if you had written it all yourself; the AI should just be used to arrive at the end result sooner.
There was a problem hiding this comment.
Your guess is correct. I am using some level of AI to skip reading all existing code. But I can assure you that once this PR goes out of draft. It will be clean.
Resolves: #32614