[Ready to review, but don't merge yet] Run ./utils/clang-format.ps1
#4630
+12,265
−11,884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qaisjp
commented
Jan 11, 2026
| return true; | ||
| } | ||
| } | ||
| } // namespace CefAppAuth |
Member
Author
There was a problem hiding this comment.
This is FixNamespaceComments which we have set to true explicitly:
Line 58 in 748adfa
Keep or no keep?
Member
There was a problem hiding this comment.
I think disable that. IDEs are more than capable of tracking namespaces these days.
qaisjp
commented
Jan 11, 2026
Comment on lines
-121
to
+132
| if (std::getenv("WINE") || std::getenv("WINEPREFIX")) { | ||
| if (std::getenv("WINE") || std::getenv("WINEPREFIX")) | ||
| { |
qaisjp
changed the title
./utils/clang-format.ps1./utils/clang-format.ps1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
clang-format.ps1executable./utils/clang-format.ps1to format all files.git-blame-ignore-revsMotivation
Make master green after #4626
Test plan
Changes were generated entirely by
./utils/clang-format.ps1