Migrate from CJS to ESM #9596
Open
Migrate from CJS to ESM #9596
+405
−589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
tobias-jarvelov
force-pushed
the
investigate-migration-from-cjs-to-esm-tb-4h-des-1739
branch
from
797147e to
28fb4df
Compare
tobias-jarvelov
force-pushed
the
investigate-migration-from-cjs-to-esm-tb-4h-des-1739
branch
2 times, most recently
from
11608e1 to
2674c07
Compare
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
tobias-jarvelov
changed the base branch from
main
to
migrate-unit-tests-from-mocha-to-vitest
tobias-jarvelov
force-pushed
the
investigate-migration-from-cjs-to-esm-tb-4h-des-1739
branch
3 times, most recently
from
0f3403d to
efb3d0f
Compare
olmoh
previously approved these changes
Jan 14, 2026
Collaborator
olmoh
left a comment
olmoh
left a comment
There was a problem hiding this comment.
Nice job, tested and works fine on macOS, LGTM.
tobias-jarvelov
force-pushed
the
investigate-migration-from-cjs-to-esm-tb-4h-des-1739
branch
from
efb3d0f to
704ee07
Compare
tobias-jarvelov
requested review from
Rawa,
albin-mullvad,
faern,
pinkisemils and
raksooo
as code owners
tobias-jarvelov
force-pushed
the
migrate-unit-tests-from-mocha-to-vitest
branch
4 times, most recently
from
a28a7ab to
9e8fc26
Compare
Base automatically changed from
migrate-unit-tests-from-mocha-to-vitest
to
main
January 16, 2026 14:20
After migrating the project to ESM the .mjs extension is used for the built preload file, however we want to retain the .js extension.
When the @vitejs/plugin-react package was updated it was no longer compatible with the TS config's `moduleResolution` setting, as such the TS config had to be updated. `moduleResolution` has to changed to `bundler`, and because of that we can no longer target `commonjs` as the output format. As such we also had to bump the `module` config option to `es2022`. With these changes in mind it made sense to also bump the TS target to `es2022` from `es2021`. The emitted code built by typescript is now a lot more modern than in previous builds.
This was previously done by the @vitejs/plugin-react package but must now be done manually.
Node now has the ability to run typescript code natively.
Since version 22.19 node natively supports executing typescript files.
tobias-jarvelov
force-pushed
the
investigate-migration-from-cjs-to-esm-tb-4h-des-1739
branch
2 times, most recently
from
49bfc50 to
4266ac9
Compare
tobias-jarvelov
force-pushed
the
investigate-migration-from-cjs-to-esm-tb-4h-des-1739
branch
from
4266ac9 to
e10f941
Compare
tobias-jarvelov
removed request for
Rawa,
albin-mullvad,
faern,
pinkisemils and
raksooo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is based on #9633
This change is