Open
Conversation
commit: |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
Contributor
|
I want to discuss this one more. I don't currently think it's useful for any design. |
Contributor
Author
|
@colmtuite it's partially useful even for anchored toasts It's somewhat of a micro-detail, but you don't want the tooltip to dismiss in the period between
The Slider label use case is indeed questionable though — because it seems like Slider should have its own tooltip-like label part, instead of trying to reuse Tooltip (as Tooltip doesn't support touch, which is yet another config option) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #4113
closeOnClickistrueby default, but this is acceptable overfalse(e.g.preventCloseOnClick) if it's for consistency with other props, andcloseOnClickis used elsewhere likeMenu.ItemDemo: https://stackblitz.com/edit/7dzwxbku?file=src%2FApp.tsx