[field] Fix field validation with simultaneous Form errors or invalid prop#4112
Open
mj12albert wants to merge 3 commits intomui:masterfrom
Open
[field] Fix field validation with simultaneous Form errors or invalid prop#4112mj12albert wants to merge 3 commits intomui:masterfrom
mj12albert wants to merge 3 commits intomui:masterfrom
Conversation
mj12albert
added
type: bug
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mj12albert
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
atomiks
reviewed
Feb 17, 2026
Comment on lines
79
to
83
| const hasFormError = | ||
| name !== undefined && | ||
| EMPTY_OBJECT.hasOwnProperty.call(errors, name) && | ||
| errors[name] !== undefined; | ||
| const invalid = invalidProp === true || hasFormError; |
Contributor
There was a problem hiding this comment.
We can use Object.hasOwn(...) now
atomiks
reviewed
Feb 17, 2026
Comment on lines
79
to
80
| const hasFormError = | ||
| name !== undefined && |
Contributor
There was a problem hiding this comment.
Codex:
[P2] Empty-string name is now handled inconsistently across form error paths. FieldRoot.tsx (line 79) now includes name="" in hasFormError, but related logic still treats empty string as “no name” in:
Form.tsx (line 138),
FieldError.tsx (line 41),
and form value collection in Form.tsx (line 122).
Leaving it as truthy name is probably simplest?
atomiks
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4095
Also handles an edge case when a field simultaneously has an error
Form.errorsandinvalid={true}