Skip to content

Comments

[all components][internal] Normalize state types and JSDoc#4101

Open
atomiks wants to merge 2 commits intomui:masterfrom
atomiks:codex/state-types-jsdoc-normalization
Open

[all components][internal] Normalize state types and JSDoc#4101
atomiks wants to merge 2 commits intomui:masterfrom
atomiks:codex/state-types-jsdoc-normalization

Conversation

@atomiks
Copy link
Contributor

@atomiks atomiks commented Feb 16, 2026

Scanned the codebase with Codex for inconsistent type declarations:

  • Ensure all State parts have JSDoc
  • Ensure internal hooks avoid namespaces
  • Ensure top-level types don't reference namespace types
  • Add missing State types

@atomiks atomiks added scope: all components Widespread work has an impact on almost all components. internal Behind-the-scenes enhancement. Formerly called “core”. labels Feb 16, 2026
@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 16, 2026

commit: 63dec74

@netlify
Copy link

netlify bot commented Feb 16, 2026

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 63dec74
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/6997dd8c9f301c00089e99f5
😎 Deploy Preview https://deploy-preview-4101--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@atomiks atomiks force-pushed the codex/state-types-jsdoc-normalization branch from 8d2f9b3 to c988be7 Compare February 16, 2026 02:31
@mui-bot
Copy link

mui-bot commented Feb 16, 2026

Bundle size report

Bundle Parsed size Gzip size
@base-ui/react 0B(0.00%) 0B(0.00%)

Details of bundle changes


Check out the code infra dashboard for more information about this PR.

@atomiks atomiks force-pushed the codex/state-types-jsdoc-normalization branch 2 times, most recently from fc8c1ef to cc279b2 Compare February 16, 2026 04:09
@atomiks atomiks marked this pull request as ready for review February 16, 2026 04:19
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 16, 2026

Too many files changed for review. (259 files found, 100 file limit)

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Feb 16, 2026
@atomiks atomiks force-pushed the codex/state-types-jsdoc-normalization branch from cc279b2 to f79e178 Compare February 17, 2026 06:10
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged. and removed PR: out-of-date The pull request has merge conflicts and can't be merged. labels Feb 17, 2026
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Behind-the-scenes enhancement. Formerly called “core”. scope: all components Widespread work has an impact on almost all components.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants