Skip to content

Comments

[docs] Cleanup old releases page rehype#4081

Open
mj12albert wants to merge 4 commits intomui:masterfrom
mj12albert:docs/cleanup-rehype
Open

[docs] Cleanup old releases page rehype#4081
mj12albert wants to merge 4 commits intomui:masterfrom
mj12albert:docs/cleanup-rehype

Conversation

@mj12albert
Copy link
Member

Not needed in the new design

@mj12albert mj12albert added the docs Improvements or additions to the documentation. label Feb 13, 2026
@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 13, 2026

commit: c4dc279

@mui-bot
Copy link

mui-bot commented Feb 13, 2026

Bundle size report

Bundle Parsed size Gzip size
@base-ui/react 0B(0.00%) 0B(0.00%)

Details of bundle changes


Check out the code infra dashboard for more information about this PR.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 13, 2026

Greptile Overview

Greptile Summary

Removes the obsolete rehype logic that was used to generate semver-prefixed heading IDs for the old releases page structure. The releases page now uses a visual timeline (ReleaseTimeline component) with individual pages for each release, making this heading transformation logic unnecessary.

Issues found:

  • The SEMVER_PATTERN constant (lines 40-41) is now unused and should be removed
  • The EXIT import (line 4) is no longer needed after removing the releases page logic
  • docs/src/components/Search/SearchBar.tsx still contains related code that expects the old releases page ID format (lines 20-38), which may need cleanup in a follow-up

Confidence Score: 3/5

  • Safe to merge with minor cleanup recommended
  • The change correctly removes obsolete code for the old releases page design. However, it leaves behind unused imports and constants (EXIT, SEMVER_PATTERN) that should be cleaned up, and there's related code in SearchBar.tsx that may also need updating
  • Pay attention to docs/src/components/QuickNav/rehypeConcatHeadings.mjs for the unused constant and import

Important Files Changed

Filename Overview
docs/src/components/QuickNav/rehypeConcatHeadings.mjs Removes obsolete releases page rehype logic; leaves unused SEMVER_PATTERN constant and related search code

Last reviewed commit: 2c21442

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 13, 2026

Additional Comments (2)

docs/src/components/QuickNav/rehypeConcatHeadings.mjs
SEMVER_PATTERN constant is now unused after removing the releases page logic and should be deleted

Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/src/components/QuickNav/rehypeConcatHeadings.mjs
Line: 38:41

Comment:
`SEMVER_PATTERN` constant is now unused after removing the releases page logic and should be deleted

```suggestion
```

How can I resolve this? If you propose a fix, please make it concise.

docs/src/components/QuickNav/rehypeConcatHeadings.mjs
EXIT import is no longer used after removing the releases page logic

import { headingRank } from 'hast-util-heading-rank';
import { toString } from 'hast-util-to-string';
import { visit, CONTINUE } from 'unist-util-visit';
import { stringToUrl } from './rehypeSlug.mjs';
Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/src/components/QuickNav/rehypeConcatHeadings.mjs
Line: 1:5

Comment:
`EXIT` import is no longer used after removing the releases page logic

```suggestion
import { headingRank } from 'hast-util-heading-rank';
import { toString } from 'hast-util-to-string';
import { visit, CONTINUE } from 'unist-util-visit';
import { stringToUrl } from './rehypeSlug.mjs';
```

How can I resolve this? If you propose a fix, please make it concise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants