Skip to content

Conversation

@me4502
Copy link
Contributor

@me4502 me4502 commented Feb 1, 2025

This PR just updates emoji-platform-data, and then reruns the augment script to pull in the new changes introduced in the newer version.

Copy link
Owner

@muan muan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review 😞.

Perhaps the facing-right is corrected upstream? I don't supposed it is easy to exclude some of these?

Comment on lines 4205 to 4206
"facing",
"right"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm not facing right. Also don't think these are useful.

@me4502
Copy link
Contributor Author

me4502 commented Jun 26, 2025

Sorry for the late reply! Yeah I agree those probably aren't useful- I'm not sure if it makes sense to try excluding these, or reporting it as an issue to upstream. I feel like emoji-platform-data actually has a bug here, where it's stripping the final ZWJ from https://emojipedia.org/woman_in_motorized_wheelchair_facing_right, and merging the data in with the left-facing version of the emoji.

I'll do some investigation

@me4502
Copy link
Contributor Author

me4502 commented Jun 26, 2025

I've just pushed a workaround that filters the incorrect ones out. It's fairly hacky, but it appears emoji-platform-data's fluemoji code is incorrectly categorising the right facing & non-ZWJ variant as the same emoji. I've confirmed that the issue is within the node_modules/emoji-platform-data/lib/data/woman-in-motorized-wheelchair.json file itself, so I'll also file a bug report on the emoji-platform-data repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants