Conversation
It will be part of the stdlib in 3.14, so lets move to that. https://peps.python.org/pep-0784/ and add some tests
Member
|
I should do the same to pacdb I guess. |
Member
Author
There is not much difference, I was mostly curious, and hoping integration would be better, but turned out to be about the same amount of code. Though this does streaming decoding in theory, if you don't read the whole thing, but we always do. |
Member
|
ok, probably better to hold off then and just switch off the zstandard code in 3.14 in favor of the included implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It will be part of the stdlib in 3.14, so lets move to that. https://peps.python.org/pep-0784/