Fix response parsing for unzipped responses #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 1611ba6 added support for unzipped responses but forgot to concatenate the buffers before converting them to a string.
Author
|
Fixes #33 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1611ba6 added support for unzipped responses but forgot to concatenate the buffers before converting them to a string. This results in a corrupt JSON string if we have more than one element in the response buffers (e.g. for a large response). If we have multiple elements in the response buffers
responseBuffers.toString()would include ',' as default concatenation character. We could also useresponseBuffers.join('')to get the same result, but withBuffer.concat(responseBuffers)we can use the same object also as parameter for the gunzip method in case the response is gzipped.