refactor: change within method to return unordered results #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrhooray
changed the title
Remove within_unsorted method and update within method to return unordered results. This provides a clear separation between ordered and unordered radius queries. - Remove within_unsorted method and benchmarks - Update within method to return unsorted results (removing sorting step) - Update tests to expect unordered results from within method - Users who need sorted radius queries should use nearest_within_radius - Simplify API surface area while improving performance for unordered radius queries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
withinmethod to return unordered results (removing sorting overhead)within_unsortedmethod and associated benchmarkswithinmethodnearest_within_radiusThis change provides a clear separation between ordered and unordered radius queries. The
withinmethod now focuses on performance with unordered results, whilenearest_within_radiushandles sorted results when distance ordering is required.