Center-of-mass velocity compute #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mphoward
force-pushed
the
feature/group-velocity
branch
2 times, most recently
from
0346778 to
b5dd1ae
Compare
mphoward
force-pushed
the
feature/group-velocity
branch
from
b5dd1ae to
9139d56
Compare
astatt
approved these changes
Jan 22, 2025
Collaborator
astatt
left a comment
astatt
left a comment
There was a problem hiding this comment.
I left some minor optional comments. I also checked that the documentation renders correctly (it does). So this looks good!
mphoward
force-pushed
the
feature/group-velocity
branch
from
65c6fe2 to
9107966
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reimplements a compute for the center-of-mass velocity of a group of particles on the CPU. Additionally, it adds support for using MPCD particles in this calculation, as well as a GPU implementation.
This is related to and based on #98 and so should be rebased and merged after that.