Update to HOOMD 5 #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mphoward
commented
Dec 6, 2024
mphoward
commented
- Update minimum version to HOOMD 5
- Configure ruff and pre-commit consistently with HOOMD 5
- Fix compile errors with version 5
- Bump RTD dependencies
astatt
approved these changes
Dec 7, 2024
Collaborator
astatt
left a comment
astatt
left a comment
There was a problem hiding this comment.
Looks good! The only thing I noticed is that when we test hoomd import, we do test if we can import hoomd.metal, and hoomd.hpmc, which I don't think we directly use in azplugins? So maybe we do not need to test the import of those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.