Refactor wall potential, colloid potential #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@mphoward Please review the updated colloid wall potential. |
mphoward
requested changes
Dec 9, 2025
Collaborator
mphoward
left a comment
mphoward
left a comment
There was a problem hiding this comment.
Thanks Jinny! This looks great. I have a couple minor find-replace type comments, then this can be merged. The main request is to precompute the coefficients sooner to save flops later on. Let me know if you have any questions!
Contributor
Author
|
@mphoward I’ve addressed the comments. Please review when you get a chance! |
mphoward
approved these changes
Dec 22, 2025
Collaborator
mphoward
left a comment
mphoward
left a comment
There was a problem hiding this comment.
Looks great, thanks Jinny!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.