Refactor wall potential, Lennard-Jones 9-3 potential #115
Conversation
mphoward
left a comment
mphoward
left a comment
There was a problem hiding this comment.
Thank you Jinny! This is really nice work. I had a couple small things I noted on the code, but they should be fix to address.
The one thing that is missing is to make sure the wall module is also linked into the sphinx documentation. Right now, it isn't getting compiled. Please see the other modules in doc/ for an example!
|
@mphoward Please review the changes. |
mphoward
left a comment
mphoward
left a comment
There was a problem hiding this comment.
Thanks Jinny! I have some final comments related to renaming one of the potential parameters for consistency with pair.Colloid, then this will be good to go. Please let me know if you have any questions about doing so!
|
@mphoward I have renamed the parameter |
mphoward
left a comment
mphoward
left a comment
There was a problem hiding this comment.
Looks great, thank you Jinny!
mphoward
changed the title
No description provided.