fix(admin): fix email bounce type display#20378
Merged
MagentaManifold merged 1 commit intomainfrom Apr 15, 2026
Merged
Conversation
Because: * email bounce types are shown as enum integers instead of strings This commit: * make the backend endpoint return transformed strings dirrectly. Closes FXA-13417
MagentaManifold
commented
Apr 15, 2026
|
|
||
| // ─── Field resolver helpers (public so integration tests can call them) ─── | ||
|
|
||
| @Features(AdminPanelFeature.AccountSearch) |
Contributor
Author
There was a problem hiding this comment.
This seems to be present for other account search methods, so I assume this one should have it as well. Same for the other one below.
There was a problem hiding this comment.
Pull request overview
Fixes the admin account search payload so email bounce types/subtypes are returned as human-readable strings (instead of numeric enum values), matching what the admin panel expects to display.
Changes:
- Transform
bounceTypeandbounceSubTypefrom numeric DB values to string enum names inemailBounces(). - Add
@Features(AdminPanelFeature.AccountSearch)metadata toemailBounces()andlinkedAccounts()helper methods.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vpomerleau
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-13417
Checklist
Put an
xin the boxes that applyHow to review (Optional)
Screenshots (Optional)
Other information (Optional)
Any other information that is important to this pull request.