Skip to content
This repository was archived by the owner on Apr 2, 2024. It is now read-only.

Conversation

@salekseev
Copy link

This supersedes #1666

@rafrombrc
Copy link
Contributor

First, thanks so much for your contribution, and I'm very sorry to have taken so long before looking at it.

Unfortunately, I'm not going to accept this PR for merging. We very much try to discourage decoders from being written in Go. I'd be much more interested in a SandboxDecoder that provided similar functionality, using either https://github.com/antirez/lua-cmsgpack or one of the native Lua msgpack implementations to do the heavy lifting. Even better would be an implementation that provided a pure Lua implementation, but which would make use of the much faster C-backed version if the module was available.

Because it's not possible at this time to implement a splitter in Lua, I'd be willing to consider merging a separate PR that only included the MsgPack splitter, but it would need to also include documentation and an entry in the CHANGES.txt changelog.

Thanks again.

@rafrombrc rafrombrc closed this Nov 19, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants