-
Notifications
You must be signed in to change notification settings - Fork 14
feat: refactor encoderfile core -> encoderfile #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
besaleli
merged 13 commits into
main
from
215-exploratory-refactor-encoderfile_core---encoderfile
Jan 12, 2026
Merged
feat: refactor encoderfile core -> encoderfile #216
besaleli
merged 13 commits into
main
from
215-exploratory-refactor-encoderfile_core---encoderfile
Jan 12, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging this PR will degrade performance by 24.3%Comparing Summary
Performance Changes
Footnotes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR merges
encoderfile-coreintoencoderfile, as discussed in #215.Changes
encoderfile-coreinto the mainencoderfilecrateencoderfile-corecrateAdditionally:
instrumentationmode tosimulationmode as described in Run benchmarks on simulation instead of instrumentation #191Rationale
The original separation existed to support on-the-fly Rust project generation and compilation during encoderfile builds. Since encoderfile builds are now pure packaging steps over prebuilt artifacts, this split no longer provides meaningful benefits and adds unnecessary complexity.
Merging the crates improves symmetry between library and CLI use cases, reduces maintenance overhead, and simplifies the build and release pipeline.
This PR is not a final refactor of
encoderfileand more breaking changes will be coming soon.