Skip to content

Conversation

@besaleli
Copy link
Member

@besaleli besaleli commented Jan 9, 2026

Description

This PR merges encoderfile-core into encoderfile, as discussed in #215.

Changes

  • Moved all functionality from encoderfile-core into the main encoderfile crate
  • Feature-gated the build CLI and related dependencies
  • Removed the standalone encoderfile-core crate
  • Updated and simplified GitHub workflows to reflect the new crate layout

Additionally:

Rationale

The original separation existed to support on-the-fly Rust project generation and compilation during encoderfile builds. Since encoderfile builds are now pure packaging steps over prebuilt artifacts, this split no longer provides meaningful benefits and adds unnecessary complexity.

Merging the crates improves symmetry between library and CLI use cases, reduces maintenance overhead, and simplifies the build and release pipeline.

This PR is not a final refactor of encoderfile and more breaking changes will be coming soon.

@besaleli besaleli linked an issue Jan 9, 2026 that may be closed by this pull request
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 9, 2026

CodSpeed Performance Report

Merging this PR will degrade performance by 24.3%

Comparing 215-exploratory-refactor-encoderfile_core---encoderfile (ce7dd3e) with main (89ae444)

Summary

⚡ 1 improved benchmark
❌ 3 (👁 3) regressed benchmarks
✅ 16 untouched benchmarks
⏩ 20 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
👁 bench_tok_cls_softmax[(16, 16, 2)] 149.2 µs 184 µs -18.91%
sequence_classification_postprocess[16] 33.6 µs 30.5 µs +10.24%
👁 bench_tok_cls_softmax[(128, 256, 32)] 27.9 ms 35.7 ms -21.65%
👁 bench_tok_cls_softmax[(32, 128, 8)] 1.4 ms 1.8 ms -24.3%

Footnotes

  1. 20 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2026

@besaleli besaleli linked an issue Jan 9, 2026 that may be closed by this pull request
@besaleli besaleli changed the title feat: exploratory refactor encoderfile core -> encoderfile feat: refactor encoderfile core -> encoderfile Jan 9, 2026
@besaleli besaleli merged commit 63411a0 into main Jan 12, 2026
5 checks passed
@besaleli besaleli deleted the 215-exploratory-refactor-encoderfile_core---encoderfile branch January 12, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exploratory: Refactor encoderfile_core -> encoderfile Run benchmarks on simulation instead of instrumentation

3 participants