-
Notifications
You must be signed in to change notification settings - Fork 711
Qt6 compile fix #3493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Qt6 compile fix #3493
Conversation
|
Is this a backport of moveit/moveit#3582? If so, why didn't you declare it like this? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3493 +/- ##
==========================================
- Coverage 46.24% 0.00% -46.23%
==========================================
Files 726 51 -675
Lines 59483 5938 -53545
Branches 7624 1057 -6567
==========================================
- Hits 27504 0 -27504
+ Misses 31813 5938 -25875
+ Partials 166 0 -166 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9df8913 to
dc039e2
Compare
|
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
c8ac1e9 to
3d8f2ef
Compare
In fact, if you compile with only Qt6, the build fails. |
Fixed a rviz_default_plugin compilation error when using qt6. The error is silent if you have qt5 and qt6 installed fix qt6 compile
fix ament_target_dependencies
Description
the patch allows compilation with both qt5 and qt6
Checklist