Upgrade infrastructure #684
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this resolves all warnings except java version
Upgrade gradle and Java with many related improvements (major breaking change)
add ability to run unit tests with convenience methods
This helps removes warnings about non deterministic finalize which is deprecated in newer java versions
close() is being called when getCompleteList(..., closeAfter) and getPartialList(..., closeAfter). So redundant code and non deterministic and deprecated anyway, might never be called by the JVM
resource is already autoclosable by contract
Big change, shiro bumped to version 2, one change in behavior is that logins do not survive restarts. So I added the remember functionality in a secure way. By default production instances will not survive login restarts UNLESS rememberme key is generated and passed to the instance
resolve more warnings and issues with java & gradle upgrades
With this fix, moqui runs properly on both embedded mode AND when deployed on a servlet container. Need to add documentation on how to test in a servlet container.
Apparently in jetty 12 on EE10+ due to the separation of websockets and EE stack from server stack, we cannot retrieve the HTTP session from websocket handshake. Therefore fixing the bug in both UserFacade and MoquiAbstractEndpoint accordingly. jetty/jetty.project#11809
This reverts commit 2afc70c.
Upgrade jetty jakarta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything is documented in release notes. This upgrades all the infrastructure used in moqui.