Fix string indexing type warnings and update type conversions #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate tests - Replace deprecated string indexing with code_unit_at() which returns UInt16 - Remove duplicate test 'CSV::parse_string/quoted_with_internal_quotes' - Rename duplicate test 'CSV::from_array/first_row_empty_with_header' to 'CSV::from_array/first_row_empty_with_header_no_generate' - Apply moon fmt formatting Co-authored-by: openhands <[email protected]>
…ssible. The bottom line is that moon check works. It would be better if moon test works. The package may not need fix. In this case, do nothing. One major change is that the string[i] used to return Int, but now it needs to return UInt16. Try to fix it by using the correct type conversion.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
==========================================
- Coverage 98.42% 98.24% -0.18%
==========================================
Files 3 3
Lines 127 114 -13
==========================================
- Hits 125 112 -13
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Note to Agent : the test case should not be removed. And the |
…ar_set - Combine multiple .trim() calls into a single call with char_set="\n\r\t " - This improves code readability and efficiency - All tests pass successfully Co-authored-by: openhands <[email protected]>
Contributor
Author
|
Turns out the test case was indeed duplicated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed type conversion warnings throughout the codebase by updating string indexing operations from
InttoUInt16return types. This change addresses compatibility issues with the latest MoonBit type system.Changes Made
Why These Changes
The MoonBit language updated its string indexing behavior where
string[i]now returnsUInt16instead ofInt. This required explicit type conversions to eliminate compiler warnings while maintaining existing functionality.Implementation Details
UInt16type conversions where string indexing occursThe changes ensure
moon checkpasses without warnings while maintaining the package's core CSV parsing capabilities.