feat(sounds): add 14 mechanical sounds (@mshareef-git)#7764
Open
mshareef-git wants to merge 2 commits intomonkeytypegame:masterfrom
Open
feat(sounds): add 14 mechanical sounds (@mshareef-git)#7764mshareef-git wants to merge 2 commits intomonkeytypegame:masterfrom
mshareef-git wants to merge 2 commits intomonkeytypegame:masterfrom
Conversation
monkeytypegeorge
added
frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I really loved using sound effects in Monkeytype cause I don't have a mechanical keyboard, but there were limited options for sounds (just about 15 or so). That's why I added 14 new mechanical keyboard soundpacks. I previously contributed similar one called Wayvibes, so I wanted to bring that variety here.
below is the summary:
Added 14 new soundpacks (IDs click17 through click30) to frontend/static/sound/.
Included Sounds: Akko Lavenders, CherryMX (Black, Blue, Brown, Red in ABS/PBT), EG Oreo, Kailh Box White, Razer Green, Shadowgun, Tealios v2, and Trust GXT 865.
Standardized naming: Followed the existing clickXX_N.wav/mp3 format for all audio files to ensure consistency with the current codebase.
Code Updates:
Updated packages/schemas/src/configs.ts to whitelist new sound IDs.
Mapped new audio assets in frontend/src/ts/controllers/sound-controller.ts.
Added UI buttons in frontend/src/html/pages/settings.html and CLI aliases in frontend/src/ts/commandline/commandline-metadata.ts.
Checks
[ ] Adding quotes?
[ ] Adding a language?
[ ] Adding a theme?
[ ] Adding a layout?
[ ] Adding a font?
[x] Check if any open issues are related to this PR; if so, be sure to tag them below.
[x] Make sure the PR title follows the Conventional Commits standard.
[x] Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.