fix(test): set burst start at composition begin for IME input (@boergeson)#7760
Open
boergeson wants to merge 1 commit intomonkeytypegame:masterfrom
Open
fix(test): set burst start at composition begin for IME input (@boergeson)#7760boergeson wants to merge 1 commit intomonkeytypegame:masterfrom
boergeson wants to merge 1 commit intomonkeytypegame:masterfrom
Conversation
…typegame#7300) Korean IME burst WPM showed absurd values (72,000+) because setBurstStart was called at compositionend, not compositionstart. The near-zero time delta caused division to produce huge numbers.
boergeson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setBurstStartwas called atcompositionendtime, notcompositionstart, making the time delta nearly zero and producing huge WPM from the divisioncompositionstartwhen beginning a new word so the timer reflects actual typing startcompositionendinonInsertTextcalculateBurstCloses #7300
Test plan