Skip to content

Conversation

@sanych-sun
Copy link
Member

@sanych-sun sanych-sun commented Jan 13, 2026

Please complete the following before merging:

  • Is the relevant DRIVERS ticket in the PR title?
  • Test changes in at least one language driver: CSharp Driver PR.
  • Test these changes against all server versions and topologies (including standalone, replica set, and sharded
    clusters).

@sanych-sun sanych-sun requested a review from a team as a code owner January 13, 2026 18:05
@sanych-sun sanych-sun requested review from ShaneHarvey and removed request for a team January 13, 2026 18:05
event:
serverDescriptionChangedEvent:
newDescription:
type: RSPrimary
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be the very first case when we filtering for type other then Unknown. I've tried to find if we have server types specified somewhere, but failed to find anything other then here. Is this a proper type value?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've used RSPrimary and Standalone as a values for server type.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, yes, the tests are passing in PyMongo: mongodb/mongo-python-driver#2678

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@dariakp dariakp merged commit 7d1d59b into mongodb:master Jan 14, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants