CSHARP-5564: Enum with ushort underlying type is not serialized correctly #1847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Note to reviewers: while reviewing this PR consider not only the fix that was made but also whether there is danger of unintended side effects that we have not detected with our existing tests. |
sanych-sun
requested changes
Jan 16, 2026
| { | ||
| throw new ArgumentException($"{typeof(TEnumUnderlyingType).FullName} is not the underlying type of {typeof(TEnum).FullName}."); | ||
| } | ||
| if (typeof(TIntegralType) != typeof(int) && typeof(TIntegralType) != typeof(long) && typeof(TIntegralType) != typeof(uint) && typeof(TIntegralType) != typeof(ulong)) |
Member
There was a problem hiding this comment.
BTW, can we use IsIntegral method here?
|
|
||
| public static bool IsIntegral(this Type type) | ||
| { | ||
| return type == typeof(int) || type == typeof(long) || type == typeof(uint) || type == typeof(ulong); |
Contributor
Author
There was a problem hiding this comment.
Modified to add all integral types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.