Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@mondaycom/apps-cli",
"version": "4.10.3",
"version": "4.10.4",
"description": "A cli tool to manage apps (and monday-code projects) in monday.com",
"author": "monday.com Apps Team",
"type": "module",
Expand Down
7 changes: 6 additions & 1 deletion src/commands/code/push.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import { Flags } from '@oclif/core';
import chalk from 'chalk';

import { AuthenticatedCommand } from 'commands-base/authenticated-command';
import { APP_ID_TO_ENTER, APP_VERSION_ID_TO_ENTER } from 'consts/messages';
import { APP_ID_TO_ENTER, APP_VERSION_ID_TO_ENTER, SECURITY_SCAN_FEEDBACK_MESSAGE } from 'consts/messages';
import { DynamicChoicesService } from 'services/dynamic-choices-service';
import { getCurrentWorkingDirectory } from 'services/env-service';
import { validateIfCanBuild } from 'services/files-service';
Expand Down Expand Up @@ -98,6 +99,10 @@ export default class Push extends AuthenticatedCommand {
const tasks = getTasksForServerSide(appVersionId, directoryPath, selectedRegion, securityScan);

await tasks.run();

if (securityScan) {
logger.log(chalk.cyan(`\n${SECURITY_SCAN_FEEDBACK_MESSAGE}`));
}
} catch (error: any) {
logger.debug(error, this.DEBUG_TAG);

Expand Down
4 changes: 3 additions & 1 deletion src/commands/code/report.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import chalk from 'chalk';
import { StatusCodes } from 'http-status-codes';

import { AuthenticatedCommand } from 'commands-base/authenticated-command';
import { APP_VERSION_ID_TO_ENTER, VAR_UNKNOWN } from 'consts/messages';
import { APP_VERSION_ID_TO_ENTER, SECURITY_SCAN_FEEDBACK_MESSAGE, VAR_UNKNOWN } from 'consts/messages';
import { DynamicChoicesService } from 'services/dynamic-choices-service';
import { getDeploymentSecurityScan } from 'services/push-service';
import { HttpError } from 'types/errors';
Expand Down Expand Up @@ -108,6 +108,8 @@ export default class Report extends AuthenticatedCommand {
} else {
logger.log('Use the -o flag to save the full report to a JSON file.');
}

logger.log(chalk.cyan(`\n${SECURITY_SCAN_FEEDBACK_MESSAGE}`));
} catch (error: unknown) {
logger.debug({ res: error }, DEBUG_TAG);
if (error instanceof HttpError) {
Expand Down
3 changes: 3 additions & 0 deletions src/consts/messages.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,6 @@ export const BUILD_ID_TO_ENTER = 'Please enter the build id of your app:';

export const LIVE_VERSION_ERROR_LOG =
'Operation failed: The latest app version is live. Create a new draft version or use --force to override';

export const SECURITY_SCAN_FEEDBACK_URL = 'https://wkf.ms/3SXbi6T';
export const SECURITY_SCAN_FEEDBACK_MESSAGE = `Share feedback on these results to help improve the security scan experience: ${SECURITY_SCAN_FEEDBACK_URL}`;
Loading