Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@mondaycom/apps-cli",
"version": "4.10.2",
"version": "4.10.3",
"description": "A cli tool to manage apps (and monday-code projects) in monday.com",
"author": "monday.com Apps Team",
"type": "module",
Expand Down
6 changes: 3 additions & 3 deletions src/commands/code/report.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@ import { APP_VERSION_ID_TO_ENTER, VAR_UNKNOWN } from 'consts/messages';
import { DynamicChoicesService } from 'services/dynamic-choices-service';
import { getDeploymentSecurityScan } from 'services/push-service';
import { HttpError } from 'types/errors';
import { SecurityScanResponse, SecurityScanResultType } from 'types/services/push-service';
import { SecurityScanResponse, SecurityScanResult } from 'types/services/push-service';
import logger from 'utils/logger';
import { addRegionToFlags, chooseRegionIfNeeded, getRegionFromString } from 'utils/region';

const DEBUG_TAG = 'code_report';

const printSecurityScanSummary = (securityScanResults: SecurityScanResultType) => {
const printSecurityScanSummary = (securityScanResults: SecurityScanResult) => {
const { summary, timestamp, version } = securityScanResults;

logger.log(`\nSecurity Scan Report (v${version})`);
Expand All @@ -31,7 +31,7 @@ const printSecurityScanSummary = (securityScanResults: SecurityScanResultType) =
};

const writeResultsToFile = (
securityScanResults: SecurityScanResultType,
securityScanResults: SecurityScanResult,
appVersionId: number,
outputDir?: string,
): string => {
Expand Down
20 changes: 10 additions & 10 deletions src/services/schemas/push-service-schemas.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,17 +47,17 @@ export const deploymentStatusTypesArray = [
export const deploymentStatusTypesSchema = z.enum(deploymentStatusTypesArray);

export const securityScanFindingSchema = z.object({
tool: z.string(),
ruleId: z.string(),
severity: z.string(),
file: z.string(),
tool: z.string().nullable(),
ruleId: z.string().nullable(),
severity: z.string().nullable(),
file: z.string().nullable(),
line: z.number().nullable(),
message: z.string(),
shortDescription: z.string(),
fullDescription: z.string(),
helpUri: z.string(),
help: z.string(),
precision: z.string(),
message: z.string().nullable(),
shortDescription: z.string().nullable(),
fullDescription: z.string().nullable(),
helpUri: z.string().nullable(),
help: z.string().nullable(),
precision: z.string().nullable(),
});

export const securityScanSchema = z.object({
Expand Down
30 changes: 2 additions & 28 deletions src/types/services/push-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,32 +18,6 @@ export type AppVersionDeploymentStatus = z.infer<typeof appVersionDeploymentStat

export const DeploymentStatusTypesSchema = deploymentStatusTypesSchema.enum;

export type SecurityScanFinding = {
tool: string;
ruleId: string;
severity: string;
file: string;
line: number | null;
message: string;
shortDescription: string;
fullDescription: string;
helpUri: string;
help: string;
precision: string;
};

export type SecurityScanResult = {
version: string;
timestamp: string;
summary: {
total: number;
error: number;
warning: number;
note: number;
};
findings: SecurityScanFinding[];
};

export type SecurityScanFindingType = z.infer<typeof securityScanFindingSchema>;
export type SecurityScanResultType = z.infer<typeof securityScanSchema>;
export type SecurityScanFinding = z.infer<typeof securityScanFindingSchema>;
export type SecurityScanResult = z.infer<typeof securityScanSchema>;
export type SecurityScanResponse = z.infer<typeof securityScanResponseSchema>;
Loading