This repository was archived by the owner on Mar 27, 2025. It is now read-only.
Correctly limit tower height calculations #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These lines previously had calls to "limit" (which was a clamp implementation) but they were of the form `limit(v, lo, v);` which is very confusing! Replacing `limit` with `clamp` caused errors so I decided to remove the calls and just use the `lo` value. This worked™ except it also allowed planes to fly through towers without hitting them. Going back and re-reading the v0.2.6 source code made me realise that `limit` was being used like `max`, so we now call `max`.
moggers87
force-pushed
the
50-collide-with-buildings
branch
from
e99ae7a to
765c7d7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These lines previously had calls to "limit" (which was a clamp implementation) but they were of the form
limit(v, lo, v);which is very confusing! Replacinglimitwithclampcaused errors so I decided to remove the calls and just use thelovalue.This worked™ except it also allowed planes to fly through towers without hitting them. Going back and re-reading the v0.2.6 source code made me realise that
limitwas being used likemax, so we now callmax.Fixes #50