fix(xpdo): Fix Illegal offset type for compound PK with generated field (#129)#272
Open
Ibochkarev wants to merge 3 commits intomodxcms:3.xfrom
Open
fix(xpdo): Fix Illegal offset type for compound PK with generated field (#129)#272Ibochkarev wants to merge 3 commits intomodxcms:3.xfrom
Ibochkarev wants to merge 3 commits intomodxcms:3.xfrom
Conversation
…ld (modxcms#129) - xPDOObject::save(): find generated field in compound PK and set value correctly - xPDOManager (MySQL): add AUTO_INCREMENT for generated fields in compound PK - Add NumberSeq test model and testSaveCompoundPkWithGeneratedField test - Fix variable initialization in testGetObjectGraphsByPK tests - Fix typo 'retreiving' -> 'retrieving' in test messages
- Add fallback in xPDOObject::save() to set _new=false when inserted with generated PK - Add NumberSeq to testGetDescendants expected array and SQLite schema - Create sqlite/NumberSeq.php for cross-platform test consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix PHP warning "Illegal offset type" when saving objects with compound primary key that includes a generated field (e.g. AUTO_INCREMENT).
Problem
When
getPK()returns an array for compound keys, the code used it as array index:$this->_fields[$this->getPK()]— PHP does not allow arrays as array keys.Solution
generated="native", and set only that field withgetGeneratedKey()getColumnDefto add AUTO_INCREMENT for generated fields in compound PK (only for the first column in PK, per MySQL requirement)Additional changes
testSaveCompoundPkWithGeneratedFieldtesttestGetObjectGraphsByPK/testGetObjectGraphsJSONByPKto avoid undefined variable noticesFixes #129