fix(core): addPackage returns result of setPackageMeta when adding/updating package#270
Open
Ibochkarev wants to merge 1 commit intomodxcms:3.xfrom
Open
Conversation
…dating package
addPackage() now assigns $added from setPackageMeta() when adding or
updating a package, so callers get false when metadata load fails
(e.g. missing or empty metadata.{dbtype}.php). When the package is
already loaded with the same path/prefix, $added remains true.
Resolves modxcms#145
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addPackage() now returns the result of setPackageMeta() when adding or updating a package, so callers get false when metadata load fails (e.g. missing or empty metadata.{dbtype}.php). When the package is already loaded with the same path/prefix, addPackage() still returns true.
Previously addPackage() always set $added = true after calling setPackageMeta(), so callers could not detect metadata load failure. setPackage() already relies on addPackage()'s return value to avoid changing the current package on failure.
We assign $added from the single setPackageMeta() call in the new/updated branch and use else { $added = true } when the package is already registered with the same path/prefix, so setPackageMeta() is not called twice.
Fixes #145