Merged
Conversation
Newer amd-smi versions nest the actual data under a `gpu_data` key. They also put generic strings in `market_name` but it looks like `board.product_name` always has what we actually want.
modularbot
pushed a commit
to modular/modular
that referenced
this pull request
Aug 22, 2025
To pull in modular/rules_mojo#45 MODULAR_ORIG_COMMIT_REV_ID: a37b72fc847e23f4868adce897b73239ee0afae9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer amd-smi versions nest the actual data under a
gpu_datakey. Theyalso put generic strings in
market_namebut it looks likeboard.product_namealways has what we actually want.