Add python_version attr to mojo_binary / mojo_test#21
Merged
Conversation
This allows forcing a target to transition to a different python version for the current target and all its deps. This allows easily testing different python versions. This revealed another issue about python version discovery, before python 3.11 if the python3 being used isn't in the PATH sys.executable would find /usr/bin/python3 even if the libpython was the correct version. This would likely only matter if something used sys.executable, but we now fix by putting python3 in the PATH.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows forcing a target to transition to a different python version
for the current target and all its deps. This allows easily testing
different python versions. This revealed another issue about python
version discovery, before python 3.11 if the python3 being used isn't in
the PATH sys.executable would find /usr/bin/python3 even if the
libpython was the correct version. This would likely only matter if
something used sys.executable, but we now fix by putting python3 in the
PATH.