feat: support nwt to mf6 binary output file conversion#2746
Open
wpbonelli wants to merge 1 commit intomodflowpy:developfrom
Open
feat: support nwt to mf6 binary output file conversion#2746wpbonelli wants to merge 1 commit intomodflowpy:developfrom
wpbonelli wants to merge 1 commit intomodflowpy:developfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #2746 +/- ##
===========================================
+ Coverage 55.5% 72.5% +16.9%
===========================================
Files 644 676 +32
Lines 124135 132800 +8665
===========================================
+ Hits 68947 96299 +27352
+ Misses 55188 36501 -18687
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support converting MODFLOW-NWT binary outputs to MF6 binary output files, for compatibility with use cases requiring MF6 outputs (e.g. MF6 PRT). Introduce a class
NwtToMf6Converterto handle the conversion.Required a few utilities:
get_icelltype_from_laytyp(): convert NWTLAYTYPto MF6ICELLTYPEget_saturation(): calculate saturation from head, cell geometry, and cell typeget_structured_flowja(): inverse ofget_structured_faceflows()MfGrdFile.write_dis(): write grb file for structured grid