Skip to content

Fix broken link #4762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tobolar wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −2
Open

Fix broken link #4762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
319a7e3
Fix broken link
tobolar Mar 10, 2026
d903414
Fix broken link - save the referenced document directly in Resources
tobolar Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Modelica/Mechanics/MultiBody/Frames/Quaternions/from_T.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ protected
algorithm
/*
This is an optimized version of the quaternion conversion based on
this paper: https://d3cw3dd2w32x2b.cloudfront.net/wp-content/uploads/2015/01/matrix-to-quat.pdf
this paper: modelica://Modelica/Resources/Documentation/Mechanics/matrix-to-quat.pdf
Copy link
Copy Markdown
Member

@beutlich beutlich Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this paper: modelica://Modelica/Resources/Documentation/Mechanics/matrix-to-quat.pdf
this paper: https://web.archive.org/web/20170718214714/https://d3cw3dd2w32x2b.cloudfront.net/wp-content/uploads/2015/01/matrix-to-quat.pdf

Copy link
Copy Markdown
Contributor Author

@tobolar tobolar Mar 30, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem to me to have a link to this source if this solution is fine also for MA.

Copy link
Copy Markdown
Member

@beutlich beutlich Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by "fine also for MA"?. There will be no approval process here. Just the usual two approving reviews are needed.

*/
if T[3, 3] < 0 then
if T[1, 1] > T[2, 2] then
Expand Down Expand Up @@ -74,7 +74,7 @@ package.
<ul>
<li>January 2021 by Jakub Tobolar<br>
reimplemented for more efficient and numerically stable algorithm according to
<a href=\"https://d3cw3dd2w32x2b.cloudfront.net/wp-content/uploads/2015/01/matrix-to-quat.pdf\">https://d3cw3dd2w32x2b.cloudfront.net/wp-content/uploads/2015/01/matrix-to-quat.pdf</a>.
<a href=\"modelica://Modelica/Resources/Documentation/Mechanics/matrix-to-quat.pdf\">matrix-to-quat.pdf</a>.
Copy link
Copy Markdown
Member

@beutlich beutlich Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a href=\"modelica://Modelica/Resources/Documentation/Mechanics/matrix-to-quat.pdf\">matrix-to-quat.pdf</a>.
<a href=\"https://web.archive.org/web/20170718214714/https://d3cw3dd2w32x2b.cloudfront.net/wp-content/uploads/2015/01/matrix-to-quat.pdf\">matrix-to-quat.pdf</a>.

It compares only one particular diagonal element with another to
select one of the four code parts. Then, the selected code delivers
four components which are close to the desired quaternion,
Expand Down
Binary file added Modelica/Resources/Documentation/Mechanics/matrix-to-quat.pdf
View file
Open in desktop
Binary file not shown.
Loading